UI scaling #115
Closed
UI scaling #115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jkeshavarzi - do you want to test this since you created the issue |
|
Code review complete |
| @@ -16,6 +16,7 @@ | |||
| <html lang="en"> | |||
| <head> | |||
| <meta charset="utf-8"> | |||
| <meta name="viewport" content="width=device-width, user-scalable=no, initial-scale=0.44"> | |||
There was a problem hiding this comment.
After some investigation we can do the following on the overlaywebview:
- Keep the "viewport" tag
- Add the following call to the webview: webview.setDevicePixelRatio : 1
|
Do not test until we make the change outlined by erikj |
|
@Pagey can you re-review please? @themainguru can you test please? |
|
Both pinch zooming and scaling with rotation on the context menu works In all cases, context menus still has a pixel ratio of 1 Testing complete. |
|
Code review complete |
|
@nukulb this can be folded? |
|
merged manually |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prevent pinch zooming on ui components using hardcoded scaling ratio for viewport.
Fixes issue #155