Skip to content
This repository has been archived by the owner on Sep 4, 2019. It is now read-only.

As a webworks developer, I can set the walllpaper #398

Closed
nukulb opened this issue Nov 27, 2012 · 8 comments
Closed

As a webworks developer, I can set the walllpaper #398

nukulb opened this issue Nov 27, 2012 · 8 comments

Comments

@nukulb
Copy link
Contributor

nukulb commented Nov 27, 2012

blackberry.system should be whitelisted

blackberry.system.setWallpaper('path')

path can either be a local:/// path or a file:// path The API must do the conversion for the user.

Implementation

qnx.webplatform.getApplication().newWallpaper(...)

@kwallis
Copy link
Member

kwallis commented Nov 28, 2012

Looks good

@jeffheifetz
Copy link
Contributor

I think system.wallpaper as a property is preferable

@tohman
Copy link
Contributor

tohman commented Nov 30, 2012

Here we have a setter only, if it property one may try to use it as getter which isn't.

@jeffheifetz
Copy link
Contributor

So just store what they set locally and return it, NBD

@tohman
Copy link
Contributor

tohman commented Nov 30, 2012

Sure storing is easy, the only confusion is when you lunch/re-lunch the app there is wallpaper but no path to it. Kind of working getter with condition described in doc. Still ok, if this is what we want. I'm for get it all or just a setter.

@jeffheifetz
Copy link
Contributor

I see, good point @tohman. setWallpaper it is then since we have no getter

@bryanhiggins
Copy link
Contributor

I don't think that makes sense. What if the wallpaper is changed manually or via another application? We would be returning the wrong value.

haahmad added a commit to blackberry-webworks/BB10-WebWorks-Framework that referenced this issue Nov 30, 2012
Fixes issue blackberry#398

Reviewed By: Hasan Ahmad <notifications@github.com>
haahmad added a commit to blackberry-webworks/BB10-WebWorks-Framework that referenced this issue Dec 2, 2012
Fixes issue blackberry#398

Reviewed By: Hasan Ahmad <haahmad@rim.com>
Tested By: Tracy Li <tli@rim.com>
@ejzn
Copy link
Contributor

ejzn commented Apr 11, 2013

close.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants