Escaped double quotes for pim.contacts #644
Conversation
| @@ -673,7 +673,7 @@ bool PimContactsQt::lessThan(const bbpim::Contact& c1, const bbpim::Contact& c2) | |||
| return temp; | |||
| } | |||
| std::string PimContactsQt::replaceString(const std::string& s) { | |||
| std::string temp = replaceAll(replaceAll(replaceAll(replaceAll(s), "\n", "\\\\n"), "\r", ""), "\t", "\\\\t"); | |||
| std::string temp = replaceAll(replaceAll(replaceAll(replaceAll(replaceAll(s), "\n", "\\\\n"), "\r", ""), "\t", "\\\\t"), "\"", "\""); | |||
There was a problem hiding this comment.
Wouldn't this make more sense as a regexp? This seems ugly.
|
@rcruz This fixes the PR: https://przilla.ott.qnx.com/bugzilla/show_bug.cgi?id=308748 |
|
Any chance that it is related? |
|
@cdelcol It is |
|
@rwmtse you beat me to it :) i'll update the PR. |
|
@DanielAudino @rwmtse Are we putting this into the Cordova branch of things....? |
|
Thanks for catching that @erikjohnzon This needs to go into cordova-blackberry-plugins otherwise no one will get in unless they're building from the GitHub repo. @EricLeiLi please make sure this is carried into the core plugin as well if necessary |
|
@EricLeiLi @haahmad did this change get into the new repos? can someone update the PR? https://przilla.ott.qnx.com/bugzilla/show_bug.cgi?id=308748 cc @grahamzibar |
|
@cdelcol No, it has not. I will open a pull request into cordova-blackberry-plugins, then use the newly built so file for pim.contacts and the cordova contacts plugins |
To remove error when finding a contact that contains special characters