This repository has been archived by the owner on Oct 9, 2018. It is now read-only.
Merging in Rory's changes #58
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added support for menu separators for Smartphones (data-bb-type="menu-separator") Added ability to set data-bb-selected="true" for menu items to be default item, if multiple are set the last one is the one that sticks for Smart Phones Removed clearMenuItems from menu setup, handled in both pushScreen and popScreen. Cleaned up check for necessary blackberry features done before setting up menu and before clearing menus to avoid throwing errors
Added usage instructions to readme.md Added menu separator for PlayBook menuBar Added copy of class(es) attached to menu and menu items Tweaked CSS for display to get colours/sizing closer to native. Cleaned up CSS file Cleaned up JS file Ported changes back to source
This reverts commit 1549230.
This reverts commit 7b2a946.
This reverts commit 6647989.
tneil
pushed a commit
that referenced
this pull request
Apr 12, 2012
Merging in Rory's additions for Menu support in bbUI
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Took the pull request from Rory, merged it with master and pushed it up into this Rory branch.. All conflicts have been resolved and it should be a clean commit.
I've tested all the bbUI controls on a BB7 device and on PlayBook 2.0 using the samples included in the repo.