Skip to content
This repository has been archived by the owner on Sep 4, 2019. It is now read-only.

Dialog and several transitions show actionbar overflowMenu #82

Closed
nsalyzyn-atimi opened this issue Dec 21, 2012 · 3 comments · Fixed by #100
Closed

Dialog and several transitions show actionbar overflowMenu #82

nsalyzyn-atimi opened this issue Dec 21, 2012 · 3 comments · Fixed by #100

Comments

@nsalyzyn-atimi
Copy link

If there is an actionbar with overflow menu, you can see the overflow menu in many undesirable situations.

  1. For example, if you do a 'swipeup' page transition, the overflow menu is completely visible while the page fades out.
  2. Another example, is if you do a pagechange using {role : 'dialog'}, the overflow menu is shown.
    I've seen it as an artifact in a few other locations, but these two are most problematic.
@jasondscott
Copy link
Contributor

Hi @nsalyzyn-atimi

Thanks for your post.

A refactor of the actionbar/overflow menus is being done which should fix this issue. The change should land sometime next week.

@nsalyzyn-atimi
Copy link
Author

Hi Jason,

Thanks for the heads up. I was in the middle of writing up an example that demonstrates:

  • slow navigation on the overflow menu
  • asking how to get an icon selected by default in the overflow menu
  • overflow menu stays selected when you touchdown inside and touchup outside
  • overflow menu ends up being allowed to scroll left and right
  • difficult to scroll the overflow menu since you'll end up selecting an item
  • the above issue

Would the example still be valuable to you if you're in the middle of a refactor? I'm nearly finished creating it.

@nsalyzyn-atimi
Copy link
Author

I added the sample code and explanations for each of the above in #92. Let me know if you'd like any elaboration. I'm a bit swamped fixing other bugs in the app we've been working on, but I can close off a bunch of QA concerns if "framework-related" issues like this get resolved.

jasondscott pushed a commit that referenced this issue Jan 12, 2013
Fixes: #71 - Small graphical glitch with tabs
Fixes: #72 - Closing the menu
Fixes: #78 - Action bar links not working
Fixes: #80 - Actionbar data-overflow="true" onClick not working
Fixes: #82 - Dialog and several transitions show actionbar overflowMenu
Fixes: #92 - Multiple issues for overflow menu with example code
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants