Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use GlobalID for all Jobs #132

Merged
merged 1 commit into from Feb 16, 2022

Conversation

jaredmoody
Copy link
Contributor

Rails provides GlobalID serialization for all activerecord objects, so there's no need to pass just the id and then find the record inside the job.

@coveralls
Copy link

coveralls commented Feb 16, 2022

Pull Request Test Coverage Report for Build 1851831760

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 6 of 6 (100.0%) changed or added relevant lines in 6 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.01%) to 96.91%

Totals Coverage Status
Change from base Build 1844834768: -0.01%
Covered Lines: 690
Relevant Lines: 712

💛 - Coveralls

@aidewoode aidewoode merged commit f73f7a1 into blackcandy-org:master Feb 16, 2022
@aidewoode
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants