[14기 최재원] step1 돔 조작과 이벤트 핸들링으로 메뉴 관리하기 #250
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
안녕하세요 |
added 2 commits
July 15, 2022 16:16
maddrake220
changed the title
Choozii
reviewed
Jul 21, 2022
| import { generateId } from "./utils/index.js"; | ||
|
|
||
| const menuName = document.querySelector("#espresso-menu-name"); | ||
| const menuForm = document.querySelector("#espresso-menu-form"); |
There was a problem hiding this comment.
저도 강의에서 봤는데요, const $ = selector = document.querySelector(selector)와 같이 util 함수로 빼놓으면 편리하다고 합니다ㅎㅎ
|
|
||
| const menuCount = document.querySelector(".menu-count"); | ||
|
|
||
| export function MenuList() { |
There was a problem hiding this comment.
components와 containers를 나눈 기준이 궁금합니당! 🤓 여러 component를 사용하는 요소가 container인 건가요..? (제 추측...)
There was a problem hiding this comment.
Presentional & Container 패턴을 사용하려고 이렇게 폴더 구조를 나눴고,
추후 리팩토링 과정을 통해 명확하게 분리하려고 합니다!
Comment on lines
+30
to
+35
| setTimeout(() => { | ||
| const edit = document.querySelector(`#edit-item-${id}`); | ||
| const remove = document.querySelector(`#remove-item-${id}`); | ||
| edit.addEventListener("click", onClickEdit); | ||
| remove.addEventListener("click", onClickDelete); | ||
| }, 10); |
There was a problem hiding this comment.
setTimeout 사용한 건 동적으로 생성된 요소들에 eventListener를 추가하기 위해서인가용??
만약 그런거라면 이벤트 위임을 사용해서 부모 요소에 eventListner를 설정해둬도 될 것 같아요!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
안녕하세요!
뉴비 개발자 최재원 입니다.
반갑습니다.