Addressed #16 #18
Merged
Addressed #16 #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nrktkt
force-pushed
the
feature/#16_optional
branch
from
7a7df76
to
0286ad5
Compare
Current coverage is 85.37%@@ master #18 diff @@
==========================================
Files 7 7
Lines 236 253 +17
Methods 0 0
Messages 0 0
Branches 33 35 +2
==========================================
+ Hits 192 216 +24
+ Misses 34 31 -3
+ Partials 10 6 -4
|
nrktkt
force-pushed
the
feature/#16_optional
branch
3 times, most recently
from
ad6e068
to
b22d761
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#16
Changed optional fields in HalLink to use java Optional.
Added HalLinkSerializer to fix odd issue where Optional is not serialized correctly despite jackson module.
Made indentation uniform