Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update API to use java Optional #16

Closed
nrktkt opened this issue Jun 16, 2016 · 0 comments
Closed

Update API to use java Optional #16

nrktkt opened this issue Jun 16, 2016 · 0 comments
Labels
enhancement help wanted

Comments

@nrktkt
Copy link
Member

nrktkt commented Jun 16, 2016

As noted by #15 some fields are null-able. These can begin to use Optional either on fields or in public method returns to be more idiomatic and try to prevent potential for null pointers. https://github.com/FasterXML/jackson-datatype-jdk8 can be used for serialization.
nrktkt added a commit that referenced this issue Jun 18, 2016
@nrktkt
Addressed #16
7a7df76 
Changed optional fields in HalLink to use java Optional.
Added HalLinkSerializer to fix odd issue where Optional is not serialized correctly despite jackson module.
Made indentation uniform
@nrktkt nrktkt mentioned this issue Jun 18, 2016
Merged
nrktkt added a commit that referenced this issue Jun 18, 2016
@nrktkt
Addressed #16
0286ad5 
Changed optional fields in HalLink to use java Optional.
Added HalLinkSerializer to fix odd issue where Optional is not serialized correctly despite jackson module.
Made indentation uniform
nrktkt added a commit that referenced this issue Jun 18, 2016
@nrktkt
Addressed #16
07cf7e8 
Changed optional fields in HalLink to use java Optional.
Added HalLinkSerializer to fix odd issue where Optional is not serialized correctly despite jackson module.
Made indentation uniform
nrktkt added a commit that referenced this issue Jun 18, 2016
@nrktkt
Addressed #16
ad6e068 
Changed optional fields in HalLink to use java Optional.
Added HalLinkSerializer to fix odd issue where Optional is not serialized correctly despite jackson module.
Made indentation uniform
nrktkt added a commit that referenced this issue Jun 18, 2016
@nrktkt
Addressed #16
b22d761 
Changed optional fields in HalLink to use java Optional.
Added HalLinkSerializer to fix odd issue where Optional is not serialized correctly despite jackson module.
Made indentation uniform
nrktkt added a commit that referenced this issue Jun 18, 2016
@nrktkt
Merge pull request #18 from blackdoor/feature/#16_optional
1ff13f2 
Addressed #16
@nrktkt nrktkt closed this as completed Jun 18, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement help wanted
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@nrktkt