Added additional verification to CoverityServerConfigBuilder

blackducksoftware · Nov 8, 2018 · f3beb71 · f3beb71
1 parent 36f3d8a
commit f3beb71
Showing 1 changed file with 10 additions and 3 deletions.
diff --git a/src/main/java/com/synopsys/integration/coverity/config/CoverityServerConfigBuilder.java b/src/main/java/com/synopsys/integration/coverity/config/CoverityServerConfigBuilder.java
@@ -30,7 +30,6 @@
 import com.synopsys.integration.coverity.CoverityServerVerifier;
 import com.synopsys.integration.exception.IntegrationException;
 import com.synopsys.integration.rest.credentials.Credentials;
-import com.synopsys.integration.rest.credentials.CredentialsBuilder;
 import com.synopsys.integration.rest.proxy.ProxyInfo;
 import com.synopsys.integration.util.BuilderStatus;
 import com.synopsys.integration.util.IntegrationBuilder;
@@ -63,6 +62,16 @@ protected CoverityServerConfig buildWithoutValidation() {
 
     @Override
     protected void validate(final BuilderStatus builderStatus) {
+        if (credentials == null) {
+            builderStatus.addErrorMessage("No Coverity credentials set.");
+            return;
+        }
+
+        if (proxyInfo == null) {
+            builderStatus.addErrorMessage("No Coverity ProxyInfo set.");
+            return;
+        }
+
         if (url == null) {
             builderStatus.addErrorMessage("No Coverity URL set.");
             return;
@@ -82,8 +91,6 @@ protected void validate(final BuilderStatus builderStatus) {
         } catch (final IntegrationException e) {
             builderStatus.addErrorMessage(e.getMessage());
         }
-
-        new CredentialsBuilder();
     }
 
     public CoverityServerConfigBuilder url(final String url) {