This repository has been archived by the owner on Jan 5, 2021. It is now read-only.
Sonar clean bomtools #312
Merged
Sonar clean bomtools #312
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Conflicts: build.gradle hub-detect/src/main/groovy/com/blackducksoftware/integration/hub/detect/bomtool/yarn/YarnLockBomTool.java hub-detect/src/main/groovy/com/blackducksoftware/integration/hub/detect/workflow/project/BdioManager.java
Conflicts: build.gradle
Conflicts: hub-detect/src/main/groovy/com/blackducksoftware/integration/hub/detect/BeanConfiguration.java hub-detect/src/main/groovy/com/blackducksoftware/integration/hub/detect/workflow/hub/HubManager.java hub-detect/src/main/groovy/com/blackducksoftware/integration/hub/detect/workflow/hub/OfflineScanner.java
taikuukaits
reviewed
Aug 7, 2018
| final DependencyGraph dependencyGraph = yarnListParser.parseYarnList(designedYarnLock, testLines); | ||
|
|
||
| final List<ExternalId> tempList = new ArrayList<>(dependencyGraph.getRootDependencyExternalIds()); | ||
|
|
||
| assertEquals(0, tempList.size()); | ||
| assertEquals(1, tempList.size()); |
There was a problem hiding this comment.
Did we change the meaning of this test?
There was a problem hiding this comment.
Yes, and it was deliberate! Yarn's logic changed and a majority of these tests were verifying the old (and incorrect) behavior of Yarn.
The test before was: If it's not in the yarn lock, make sure we don't add it to the list.
The test now is: if it's not in the yarn lock, make sure we add it to the list.
taikuukaits
approved these changes
Aug 7, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updating a few bomtools to clean up some sonar smells.