Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial support for Forth #11

Merged
merged 1 commit into from Mar 6, 2012
Merged

Conversation

dcsobral
Copy link

This is based on the Scala parser, which is actually quite
incorrect -- assumes existence of single-quote strings (which
will cause problem on any file with symbols), doesn't know
multiline strings, doesn't handle nested comments: all of which
made it a pretty good starting point for Forth.

Parsing Forth is impossible, but this will recognize comments,
strings and blank lines on most projects. Tested against FreeBSD
source.

This is based on the Scala parser, which is actually quite
incorrect -- assumes existence of single-quote strings (which
will cause problem on any file with symbols), doesn't know
multiline strings, doesn't handle nested comments: all of which
made it a pretty good starting point for Forth.

Parsing Forth is impossible, but this will recognize comments,
strings and blank lines on most projects. Tested against FreeBSD
source.
@dcsobral
Copy link
Author

It doesn't recognize .fs files, as that would require disambiguation against f-sharp. Let whoever has .fs Forth files handle this.

@dcsobral
Copy link
Author

Also... can we please have a revised README? The present one has a broken link to issues, and points to another repo altogether as the source repo.

@robinluckey
Copy link

Hi dcsobral,

Thanks for the great patch. I'm actually surprised to discover that we didn't already have Forth support. This is probably the most popular language that we didn't yet support.

I've merged this into the Ohloh production master, but it will take another 2 or 3 weeks before it is deployed to our production website. At that point, we'll have to manually start clean line counts for all of the Forth projects on Ohloh. If there are particular projects you'd like me to count first, just let me know.

I'm sorry the README has fallen out of date. I will spend a few minutes to makes sure that at least the essential bits are correct.

Thanks so much for your help,

Robin

robinluckey pushed a commit that referenced this pull request Mar 6, 2012
Initial support for Forth
@robinluckey robinluckey merged commit 23d929c into blackducksoftware:master Mar 6, 2012
@dcsobral
Copy link
Author

dcsobral commented Mar 6, 2012

Thanks. My own personal interest is FreeBSD: Forth was the reason I first became a contributor.

robinluckey pushed a commit that referenced this pull request Apr 18, 2012
Add sty and cls for LANG_TEX, add dtx and LANG_TEX_DTX
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants