Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update black duck common version #135

Merged
merged 7 commits into from Mar 16, 2020

Conversation

crowleySynopsys
Copy link
Contributor

Updated bd-common version to 47.0.1

@blackduck-copilot
Copy link

Black Duck Security Report

Merging #135 into master will not change security risk.

Added Components

Clean: 1

Removed Components

Clean: 1

Click here to see full report

@JakeMathews
Copy link
Contributor

Why are we using an extended enum if we don't care about the extended value?

@crowleySynopsys
Copy link
Contributor Author

Why are we using an extended enum if we don't care about the extended value?

Honestly I wasn't really sure about the Extended value, I was just trying to mimic the implementation of snippet matching since it's also an enum we pass to the scanner. Since we omitted none from the individual file matching enum, I didn't know what to set for the default since I think we essentially want the property to be null if not set to one of the three accepted values but the default parameter is non-null

@JakeMathews
Copy link
Contributor

Why are we using an extended enum if we don't care about the extended value?

Honestly I wasn't really sure about the Extended value, I was just trying to mimic the implementation of snippet matching since it's also an enum we pass to the scanner. Since we omitted none from the individual file matching enum, I didn't know what to set for the default since I think we essentially want the property to be null if not set to one of the three accepted values but the default parameter is non-null

You don't need to supply a default value to nullable properties. I think what you want to use is NullableEnumProperty.

@taikuukaits
Copy link
Contributor

I think he does want to use extended enum with NONE. Because the only extended enum value is NONE at the moment he doesn't actually care about it's value. I think he had it correct. We don't want "not-present" to be none. We want a default value of NONE just like snippet matching.

@sonarcloud
Copy link

sonarcloud bot commented Mar 16, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 1 Code Smell

33.3% 33.3% Coverage
0.0% 0.0% Duplication

@crowleySynopsys crowleySynopsys merged commit b06ede8 into master Mar 16, 2020
@dmamidisynopsys dmamidisynopsys deleted the updateBlackDuckCommonVersion branch June 7, 2023 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants