New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update black duck common version #135
Conversation
…w enum for individual.file.matching property
Black Duck Security ReportMerging #135 into master will not change security risk. Added ComponentsClean: 1 Removed ComponentsClean: 1 |
src/main/java/com/synopsys/integration/detect/configuration/DetectConfigurationFactory.kt
Show resolved
Hide resolved
Why are we using an extended enum if we don't care about the extended value? |
Honestly I wasn't really sure about the Extended value, I was just trying to mimic the implementation of snippet matching since it's also an enum we pass to the scanner. Since we omitted none from the individual file matching enum, I didn't know what to set for the default since I think we essentially want the property to be null if not set to one of the three accepted values but the default parameter is non-null |
You don't need to supply a default value to nullable properties. I think what you want to use is NullableEnumProperty. |
I think he does want to use extended enum with NONE. Because the only extended enum value is NONE at the moment he doesn't actually care about it's value. I think he had it correct. We don't want "not-present" to be none. We want a default value of NONE just like snippet matching. |
Kudos, SonarCloud Quality Gate passed! 0 Bugs |
Updated bd-common version to 47.0.1