Sb sonarcloud issues #142
Merged
Sb sonarcloud issues #142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
taikuukaits
reviewed
Mar 31, 2020
| private boolean inQuotes = false; | ||
| private boolean quoteTypeIsDouble = false; | ||
|
|
||
| public boolean isLastCharWasEscapeChar() { |
There was a problem hiding this comment.
I'd prefer we changed this as it reads strangely to me. So instead of "isLastCharWasEscapeChar" we could do "wasLastCharEscapeChar".
There was a problem hiding this comment.
Or if we wanted to keep the "is" maybe "isLastCharEscapeChar".
| return inQuotes; | ||
| } | ||
|
|
||
| public boolean isQuoteTypeIsDouble() { |
There was a problem hiding this comment.
Similarly this reads strangely. Maybe "isDoubleQuoteType" instead.
JakeMathews
reviewed
Mar 31, 2020
Comment on lines
110
to
112
| if (!parserState.isInQuotes()) { | ||
| processNonQuotedChar(parserState, c, newString); | ||
| } else { |
There was a problem hiding this comment.
Small nitpick, but could we swap the if so we aren't negating the statement? I think it makes it easier to read.
JakeMathews
approved these changes
Mar 31, 2020
|
Kudos, SonarCloud Quality Gate passed!
|
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addressed the quality gate problems in clang and bazel