refactor(): Edits for sonarCloud critical code smells #157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crowleySynopsys
requested review from
stevebillings,
taikuukaits and
JakeMathews
JakeMathews
suggested changes
Apr 22, 2020
...in/java/com/synopsys/integration/configuration/source/SpringConfigurationPropertySource.java
Show resolved
Hide resolved
detectable/src/main/java/com/synopsys/integration/detectable/SingleDetectableApplication.java
Show resolved
Hide resolved
...src/main/java/com/synopsys/integration/detectable/detectable/file/impl/SimpleFileFinder.java
Outdated
Show resolved
Hide resolved
...rc/main/java/com/synopsys/integration/detectable/detectables/nuget/model/NugetContainer.java
Show resolved
Hide resolved
...src/main/java/com/synopsys/integration/detectable/detectables/yarn/parse/YarnLockParser.java
Outdated
Show resolved
Hide resolved
src/main/java/com/synopsys/integration/detect/interactive/mode/InteractiveMode.java
Show resolved
Hide resolved
src/main/java/com/synopsys/integration/detect/lifecycle/run/RunManager.java
Outdated
Show resolved
Hide resolved
src/main/java/com/synopsys/integration/detect/tool/detector/DetectorTool.java
Outdated
Show resolved
Hide resolved
src/main/java/com/synopsys/integration/detect/workflow/diagnostic/DiagnosticLogUtil.java
Show resolved
Hide resolved
Black Duck Security ReportMerging #157 into master will not change security risk. |
JakeMathews
suggested changes
Apr 24, 2020
There was a problem hiding this comment.
In addition to the comments, I am a little concerned about including DetectorTool in this PR. It's risky. Our only test for that class ensures that it fails when it's supposed to, but does not test the positive case. Perhaps that class is a candidate for 6.4.0.
...src/main/java/com/synopsys/integration/detectable/detectables/yarn/parse/YarnLockParser.java
Outdated
Show resolved
Hide resolved
...src/main/java/com/synopsys/integration/detectable/detectables/yarn/parse/YarnLockParser.java
Outdated
Show resolved
Hide resolved
JakeMathews
approved these changes
Apr 24, 2020
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Edits for Critical code smells according to SonarCloud. Included classes have what I consider to be reasonable test coverage, or the edits are minor enough that they pose no risk.