fix(go): Make list -u work for Go 1.14+ #209
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The latest update, 6.4.0, broke Go dependency resolution for Go version 1.14.x because
go list -m -u
requires-mod=mod
or-mod=readonly
now. However, only Go 1.13+ actually supports the command at all, 1.12 returns an error if you try.Implementation notes
I tried doing this via .execute and catching the exception, but then it causes an error in the report, and I don't think that's avoidable, unless I use a different method of execution? Not really sure. Because of that, I preferred parsing the version number instead. If there's a way to do it via try/catch without logging the error in the try block, let me know.
The reason I parsed it this way was because the version can have arbitrary prefixes like "devel", seems safer just to do this.