Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SSL + arguments + python3 + skip collectors #10

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

jweyrich
Copy link

@jweyrich jweyrich commented Apr 27, 2016

Hi,

First, I'd like to thank you because your project is quite handy for us (@teltec).
Second, I implemented a few extra things we needed, so I'd would like to contribute back ;-)

  • Support SSL connection to Zabbix server using client certificate - Requires Python>=2.7.9 (introduced SSLContext);
  • Make script compatible with Python 3;
  • Add support for arguments;
  • Add support to skip a data collector;

NOTE: I didn't update the README though :/ I'll try in my spare time.

Please, let me know if you find any problem(s) or have any concerns.

- Make script compatible with Python 3;
- Add support for arguments;
- Add support to skip a data collector;
from __future__ import unicode_literals

import sys
is_python_3 = sys.version_info > (3, 0)
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it works only for 3.0?

Copy link
Author

@jweyrich jweyrich May 11, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works for >=2.7.9 and >=3 as far as I tested.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants