Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update for disabled module #3

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Update for disabled module #3

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a3b6968
Update for disabled module
alexpts Mar 29, 2021
df04168
Update Abstract/abstract-blackfire-php-extension.rb
alexpts Sep 3, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion Abstract/abstract-blackfire-php-extension.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -164,7 +164,7 @@ def config_filepath
def write_config_file
if config_filepath.file?
inreplace config_filepath do |s|
s.gsub!(/^(zend_)?extension=.+$/, "extension=\"#{module_path}\"")
s.gsub!(/^(;\s*)?(zend_)?extension=.+$/, "extension=\"#{module_path}\"")
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should it not be

Suggested change
s.gsub!(/^(;\s*)?(zend_)?extension=.+$/, "extension=\"#{module_path}\"")
s.gsub!(/^(;\s*)?(zend_)?extension=.+$/, "\\1extension=\"#{module_path}\"")

Otherwise, it explicitly enables the module which has been disabled, so it must be manually disabled again.

end
elsif config_file
config_scandir_path.mkpath
Expand Down