Fix crash on AsyncWebServerRequest::_removeNotInterestingHeaders(), c…

…aused by deletion from the linked list while looping.
blackhack · Oct 16, 2023 · 139a97a · 139a97a
1 parent c7fb6c5
commit 139a97a
Showing 1 changed file with 8 additions and 3 deletions.
diff --git a/src/WebRequest.cpp b/src/WebRequest.cpp
@@ -180,10 +180,15 @@ void AsyncWebServerRequest::_onData(void *buf, size_t len){
 
 void AsyncWebServerRequest::_removeNotInterestingHeaders(){
   if (_interestingHeaders.containsIgnoreCase("ANY")) return; // nothing to do
-  for(const auto& header: _headers){
-      if(!_interestingHeaders.containsIgnoreCase(header->name().c_str())){
+
+  auto itr = _headers.begin();
+  while (itr != _headers.end())
+  {
+      const auto header = *itr;
+      ++itr; // ++operator before remove(), otherwise itr becomes invalid
+
+      if (!_interestingHeaders.containsIgnoreCase(header->name().c_str()))
         _headers.remove(header);
-      }
   }
 }