Controls #21
Merged
Controls #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blackjack
reviewed
Jan 12, 2019
|
OK review comments incorporated. Please take another look. |
|
Travis has some complains. Could you please also fix that? Thank you. |
|
Ok fixed, though there is an unrelated breakage for go 1.4 (I presume that was pre-existing). |
|
Heh, apparently golang 1.6 is now broken and I have to raise minimal supported version to 1.7. |
|
Thank you very much for your contribution. In the meantime I'll update travis config. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add code to get or set controls.