Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Twitch fix #34

Merged
merged 6 commits into from Sep 3, 2020
Merged

Twitch fix #34

merged 6 commits into from Sep 3, 2020

Conversation

blackjack4494
Copy link
Owner

Preferring this PR by @lel-amri
ytdl-org#21812

it's older and looks a bit cleaner (but that's only to my personal preference - nothing wrong with the alternative) @willbeaufoy
alternative
ytdl-org#25010

related issues
ytdl-org#21811
ytdl-org#24263
ytdl-org#25553

Twitch changed its URLs for user's videos lists recently. This commit includes
fixes for "past broadcasts", "hightlights" and "uploads".
Also fixed a bug because of removed TwitchVideoIE and TwitchChapterIE
Reverted the modification of youtube_dl/extractor/extractors.py since TwitchAllVideosIE now only matches on URLs with filter=all or without any parameters
@blackjack4494
Copy link
Owner Author

PS D:\gitkraken\youtube-dl> python3 -m youtube_dlc https://www.twitch.tv/repazmois/videos?filter=highlights -F
[twitch:videos:highlights] repazmois: Downloading channel info JSON
[twitch:videos:highlights] 101020771: Downloading highlights JSON page 1
[twitch:videos:highlights] 101020771: Downloading highlights JSON page 2
[twitch:videos:highlights] 101020771: Downloading highlights JSON page 3
[twitch:videos:highlights] 101020771: Downloading highlights JSON page 4
[twitch:videos:highlights] 101020771: Downloading highlights JSON page 5
[download] Downloading playlist: repazmois
[twitch:videos:highlights] playlist repazmois: Collected 361 video ids (downloading 361 of them)
[download] Downloading video 1 of 361
[twitch:vod] 729100286: Downloading vod info JSON
[twitch:vod] 729100286: Downloading vod access token
[twitch:vod] 729100286: Downloading m3u8 information
[info] Available formats for v729100286:
format code extension resolution note
Audio_Only mp4 audio only 13k , mp4a.40.2
160p mp4 284x160 230k , avc1.4D400C, 30.0fps, mp4a.40.2
360p mp4 640x360 630k , avc1.4D401E, 30.0fps, mp4a.40.2
480p mp4 852x480 1200k , avc1.4D401E, 30.0fps, mp4a.40.2
720p mp4 1280x720 2100k , avc1.4D401F, 30.0fps, mp4a.40.2
720p60 mp4 1280x720 3100k , avc1.4D401F, 60.0fps, mp4a.40.2
1080p60 mp4 1920x1080 Source 6633k , avc1.64002A, 61.0fps, mp4a.40.2 (best)
[download] Downloading video 2 of 361

@blackjack4494 blackjack4494 merged commit dac4ecf into blackjack4494:master Sep 3, 2020
This was referenced Sep 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants