[Vlive] Fix playlist handling when downloading a channel #224
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please follow the guide below
x
into all the boxes [ ] relevant to your pull request (like that [x])Before submitting a pull request make sure you have:
In order to be accepted and merged into youtube-dl each piece of code must be in public domain or released under Unlicense. Check one of the following options:
What is the purpose of your pull request?
Description of your pull request and other information
This fixes issue #222 .
I have debugged the issue and found that program attempts to download http://www.vlive.tv/video/${playlist_id}, instead of http://www.vlive.tv/video/${playlist_video_id}, where playlist_video_id denotes one of video_id within the playlist.
As http://www.vlive.tv/video/${playlist_id} is not a valid url, program fails when attempting to download it.
The fix will check the type of an entry using 'videoType', and if the type is 'PLAYLIST', it parses webpage data to obtain all the video_ids in the playlist.
Using the obtained video_ids (i.e., playlist_video_ids) it will append valid video urls http://www.vlive.tv/video/${playlist_video_id} to entries variable.