Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Vlive] Fix playlist handling when downloading a channel #224

Merged
merged 1 commit into from Nov 30, 2020
Merged

[Vlive] Fix playlist handling when downloading a channel #224

merged 1 commit into from Nov 30, 2020

Conversation

kyuyeunk
Copy link
Contributor

Please follow the guide below

  • You will be asked some questions, please read them carefully and answer honestly
  • Put an x into all the boxes [ ] relevant to your pull request (like that [x])
  • Use Preview tab to see how your pull request will actually look like

Before submitting a pull request make sure you have:

In order to be accepted and merged into youtube-dl each piece of code must be in public domain or released under Unlicense. Check one of the following options:

  • I am the original author of this code and I am willing to release it under Unlicense
  • I am not the original author of this code but it is in public domain or released under Unlicense (provide reliable evidence)

What is the purpose of your pull request?

  • Bug fix
  • Improvement
  • New extractor
  • New feature

Description of your pull request and other information

This fixes issue #222 .

I have debugged the issue and found that program attempts to download http://www.vlive.tv/video/${playlist_id}, instead of http://www.vlive.tv/video/${playlist_video_id}, where playlist_video_id denotes one of video_id within the playlist.

As http://www.vlive.tv/video/${playlist_id} is not a valid url, program fails when attempting to download it.

The fix will check the type of an entry using 'videoType', and if the type is 'PLAYLIST', it parses webpage data to obtain all the video_ids in the playlist.

Using the obtained video_ids (i.e., playlist_video_ids) it will append valid video urls http://www.vlive.tv/video/${playlist_video_id} to entries variable.

@blackjack4494 blackjack4494 merged commit 8e423ae into blackjack4494:master Nov 30, 2020
siikamiika pushed a commit to siikamiika/yt-dlc that referenced this pull request Jun 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants