Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

small error in Introduction.ipynb: you accidently use the wrong kernel #112

Closed
murphyk opened this issue Sep 13, 2021 · 2 comments
Closed

small error in Introduction.ipynb: you accidently use the wrong kernel #112

murphyk opened this issue Sep 13, 2021 · 2 comments
Assignees
@rlouf
Labels
adaptation Issue related to the adaptation bug Something isn't working documentation Improvements or additions to documentation refactoring Change that adds no functionality but improves code quality
Milestone
1.0

Comments

@murphyk
Copy link
Contributor

murphyk commented Sep 13, 2021

In cell 19 of Introduction.ipynb you create kernel using STAN warmup, but in cell 20, you use the old nuts_kernel which created earlier without using warmup.
@rlouf
Copy link
Member

rlouf commented Sep 17, 2021

You're right, and it also seems that there is a bug in the Stan warmup as I only get divergences when I use the kernel built with the parameters returned by the warmup ! This should not happen with such a simple model. I'll open a new issue and leave this one open.

@rlouf rlouf added documentation Improvements or additions to documentation refactoring Change that adds no functionality but improves code quality labels Sep 17, 2021
@rlouf rlouf mentioned this issue Sep 17, 2021
Closed
@rlouf rlouf added the bug Something isn't working label Dec 22, 2021
@rlouf rlouf added this to the 1.0 milestone Jun 29, 2022
@rlouf rlouf self-assigned this Jun 29, 2022
@rlouf rlouf added the adaptation Issue related to the adaptation label Jul 3, 2022
rlouf added a commit that referenced this issue Jul 3, 2022
@rlouf
Use the right kernel in Introduction notebook (#112)
a29272d
@rlouf
Copy link
Member

rlouf commented Jul 3, 2022

This was solved with a29272d. It also appears that previous work on adaptation solved all known issues with it. Great news!

@rlouf rlouf closed this as completed Jul 3, 2022
junpenglao pushed a commit that referenced this issue Mar 12, 2024
@rlouf @junpenglao
Use the right kernel in Introduction notebook (#112)
f02daef
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rlouf rlouf

Labels
adaptation Issue related to the adaptation bug Something isn't working documentation Improvements or additions to documentation refactoring Change that adds no functionality but improves code quality
Projects
None yet
Milestone
1.0
Development

No branches or pull requests
2 participants
@rlouf @murphyk