Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve window adaptation #44

Closed
wants to merge 9 commits into from
Closed

Improve window adaptation #44

wants to merge 9 commits into from

Conversation

rlouf
Copy link
Member

@rlouf rlouf commented Jun 5, 2021

While the warmup performs correctly on most examples, it fails on a simple gaussian target. The goal of this PR is to diagnose and solve the issue.

@codecov
Copy link

codecov bot commented Jun 5, 2021

Codecov Report

❗ No coverage uploaded for pull request base (main@7a4e545). Click here to learn what that means.
The diff coverage is n/a.

❗ Current head 3ced06e differs from pull request most recent head 4630047. Consider uploading reports for the commit 4630047 to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##             main      #44   +/-   ##
=======================================
  Coverage        ?   96.87%           
=======================================
  Files           ?       15           
  Lines           ?      639           
  Branches        ?        0           
=======================================
  Hits            ?      619           
  Misses          ?       20           
  Partials        ?        0           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7a4e545...4630047. Read the comment docs.

@rlouf rlouf changed the title fix Stan warmup Improve window adaptation Aug 4, 2021
@rlouf rlouf mentioned this pull request Aug 5, 2021
@rlouf rlouf added this to the 0.3.0 milestone Aug 5, 2021
@rlouf rlouf self-assigned this Jan 23, 2022
@junpenglao junpenglao linked an issue Feb 8, 2022 that may be closed by this pull request
@rlouf
Copy link
Member Author

rlouf commented Mar 29, 2022

Closing as the warmup has significantly changed since this PR.

@rlouf rlouf closed this Mar 29, 2022
@rlouf rlouf deleted the dual_averaging branch March 29, 2022 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Parameters returned by the warmup are off
1 participant