forked from vitch/jScrollPane
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Added the destroy() method to the public API.
This is a way to remove undo the jScrollPane method Signed-off-by: <blackjid>
- Loading branch information
unknown
committed
Oct 29, 2010
1 parent
9ef95f7
commit d3cdee3
Showing
1 changed file
with
14 additions
and
0 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d3cdee3
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it could be improved.
.removeAttr("style").removeAttr("tabindex")
This should instead restore previous values if there were any
Also pane.children().unwrap().unwrap() could be improved. For example, pane.children().detach().appendTo(elem.empty());
Or probably even make a var clone = elem.clone().empty(); when initializing so that it keeps all the original attributes and then just elem.replace(clone.append(pane.children()));