Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Ability to Kill Modules During Scan #751

Merged
merged 1 commit into from
Sep 22, 2023
Merged

Conversation

TheTechromancer
Copy link
Collaborator

@TheTechromancer TheTechromancer commented Sep 20, 2023

Addresses #750.

During a scan, you can now type kill <module>, e.g. kill nmap and press enter. This will kill the module and remove its events from the queue.

@codecov
Copy link

codecov bot commented Sep 20, 2023

Codecov Report

Merging #751 (9cb214b) into dev (6e17307) will decrease coverage by 0%.
The diff coverage is 50%.

@@          Coverage Diff          @@
##             dev    #751   +/-   ##
=====================================
- Coverage     92%     92%   -0%     
=====================================
  Files        284     284           
  Lines      16692   16709   +17     
=====================================
- Hits       15243   15240    -3     
- Misses      1449    1469   +20     
Files Changed Coverage Δ
bbot/scanner/manager.py 90% <34%> (-<1%) ⬇️
bbot/modules/base.py 89% <50%> (-1%) ⬇️
bbot/cli.py 85% <55%> (-2%) ⬇️

... and 2 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@aconite33 aconite33 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love it. One thing I would consider is that when BBoT runs, to have an interactive CLI.

That way you have a consistent line that does not change, while the rest of the spam of the logs are still scrolling. Just a thought, and more of a quality of life. I'll see if I can find an example (I'm thinking something like Metasploit in the back of my head)

@TheTechromancer TheTechromancer merged commit 76b4315 into dev Sep 22, 2023
5 checks passed
@TheTechromancer TheTechromancer mentioned this pull request Sep 22, 2023
@TheTechromancer TheTechromancer deleted the kill-modules branch November 8, 2023 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants