Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add MSVC and macOS coverage #1748

Merged
merged 7 commits into from
Jan 27, 2024

Conversation

amyspark
Copy link
Contributor

Detailed description

This PR implements CI support for MSVC, Apple Xcode, and Homebrewed GCC for macOS.

For the latter two, dependencies are fetched from Homebrew as:

  • libftdi depends on boost and others to be built from scratch
  • GCC cannot build hidapi due to extensive usage of Objective-C constructs

This PR also includes the relevant fixes to make MSVC builds happy, in particular around standards compliance (#1742).

I'm open to any feedback. Let me know what you think!

Your checklist for this pull request

Closing issues

@dragonmux dragonmux added this to the v2.0 release milestone Jan 26, 2024
@dragonmux dragonmux added Enhancement General project improvement BMD App Black Magic Debug App (aka. PC hosted) (not firmware) CI Continuous Integration System Build system Build system labels Jan 26, 2024
Copy link
Member

@dragonmux dragonmux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only got a couple of notes as this all looks pretty great - with them addressed, this looks good to merge.

meson.build Outdated Show resolved Hide resolved
src/target/riscv_debug.c Outdated Show resolved Hide resolved
src/target/semihosting.c Outdated Show resolved Hide resolved
Copy link
Contributor Author

@amyspark amyspark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dragonmux thanks for the comments! Bits should've been addressed now.

Copy link
Member

@dragonmux dragonmux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, merging. Thank you for the contribution!

@dragonmux dragonmux merged commit 6201df9 into blackmagic-debug:main Jan 27, 2024
24 checks passed
@amyspark amyspark deleted the add-meson-coverage branch April 28, 2024 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BMD App Black Magic Debug App (aka. PC hosted) (not firmware) Build system Build system CI Continuous Integration System Enhancement General project improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants