New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added support for kinetis MK20DX256 chip #1797
Added support for kinetis MK20DX256 chip #1797
Conversation
Before we review, do note that we recommend upgrading your ARM GCC to GCC 12.2.Rel1 - this has better diagnostics and better code generation, which is why the resulting binaries from it do fit in Flash. |
Yeah, this needs to change - so please use defines in this PR so less has to be fixed later in a follow-up PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Taking into account the comment about defines, the rest of this looks great and we'll be happy to merge this once that's been sorted.
Changed to defines :) Still can't get it to build though, these are the commands:
|
You have RTT enabled in that build, which presently does not fit on native without turning off some targets due to the space constraint - this looks to be the cause. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, merging once the builds complete. Thank you for the contribution!
Great, thanks a lot for guidance. Enjoy your weekend! |
Detailed description
This PR adds support for a MK20DX256 chip in
kinetis.c
. It specifies flash region, both RAM segments and FlexNVM. It doesn't, however, add support for FlexRAM that this chip features. That support seems to lack from all other kinetis targets too, I guess due to the complication that this region can be configured both as RAM and EEPROM.One of the comments made on the branch was to use defines instead of addresses directly, which doesn't seem to be common practice in
kinetis.c
. So for now I added the values directly as function arguments. If that's still desired, I can make a change :)Your checklist for this pull request
The following was tested on Tiva ICDI platform, with GDB 8.3.1:
Closing issues
No known open issues.