Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The s binding is a bit confusing when border is disabled or the text is too short #128

Closed
ilyagr opened this issue Jun 10, 2024 · 2 comments · Fixed by #134
Closed

The s binding is a bit confusing when border is disabled or the text is too short #128

ilyagr opened this issue Jun 10, 2024 · 2 comments · Fixed by #134
Milestone

Comments

@ilyagr
Copy link
Contributor

ilyagr commented Jun 10, 2024

The s binding does nothing when the border is disabled or if the window fits on one screen, which is a bit confusing.

Perhaps b could be a tri-state toggle: no border, border without scrollbar, border with scrollbar?

When the scrollbar is on, the whole "border" could be drawn thick as though it was a huge scrollbar (just to make it less confusing that these are two different states).

@ilyagr
Copy link
Contributor Author

ilyagr commented Jun 10, 2024

I'm also wondering if there's a good way to set up the UI so that the border only shows when either 1) the title or history are shown or 2) the scrollbar is needed.

This could be command-line option, but I'm not currently sure what exactly the b keybinding should do in that case (or s if it still exists). It doesn't work perfectly with my tri-state idea since b would do nothing in certain cases. Perhaps the keybinding can be documented as "toggle border and scrollbar (when applicable)", I'm unsure.

@ilyagr ilyagr changed the title The s binding is confusing when border is disabled or the text is too short The s binding is a bit confusing when border is disabled or the text is too short Jun 10, 2024
@blacknon
Copy link
Owner

Come to think of it, maybe you are right.
Since I had created the METHOD separately, I had implemented the key bindings separately for the time being.

In the next version at 0.3.15, change the default behavior to a toggle that enables/disables the border and scrollbars as a set.

@blacknon blacknon added this to the 0.3.15 milestone Jun 11, 2024
blacknon added a commit that referenced this issue Jun 12, 2024
@blacknon blacknon mentioned this issue Jun 12, 2024
blacknon added a commit that referenced this issue Jun 12, 2024
@blacknon blacknon mentioned this issue Jun 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants