Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replacement of the query #200

Merged
merged 5 commits into from
Jun 14, 2024
Merged

Replacement of the query #200

merged 5 commits into from
Jun 14, 2024

Conversation

Andrew-Morozko
Copy link
Contributor

@Andrew-Morozko Andrew-Morozko commented Jun 11, 2024

Update all references to query and query_result

  • query and .query_result removal
  • data.inline removal

The only references to query, .query_result, and data.inline are now only in documentation. Perhaps #199 can take care of updating them @traut ?

@Andrew-Morozko Andrew-Morozko marked this pull request as ready for review June 12, 2024 15:37
# item_template = "[{{.Title}}]({{.URL}})"
#
# Default value:
item_template = "{{.}}"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Decided that item_template being {{.}} is a good default

@traut
Copy link
Member

traut commented Jun 14, 2024

for sure, I'll take care of updating the docs

@Andrew-Morozko Andrew-Morozko merged commit cb5506d into main Jun 14, 2024
7 checks passed
@Andrew-Morozko Andrew-Morozko deleted the query branch June 14, 2024 16:52
api_key = "some string"
# Optional string.
# Default value:
api_key = null
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wait, I don't think it's optional?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants