fix: decoding struct and union fields with ambiguous types #59
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
@"
sequence is ambiguous when used inside structs and unions. This patch makes go-macho correctly decode these types based on the behaviour of clang.{S="Id"@"NSString"^{S}}
struct S { id Id; struct S *NSString; }
{S="Id"@"NSString""NSString"^{S}}
struct S { NSString *Id; struct S *NSString; }
{?=@"NSString"^{S}}
struct { NSString *; struct S *; }
Before:
After: