add statistics page #25
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add statistics page with top25 posts (worktime) add new resource: minified Chart.js
remove nonsense else statement
blackus3r
requested changes
Oct 23, 2016
|
|
||
| return; | ||
| } | ||
| echo 'no data.'; |
There was a problem hiding this comment.
Please use echo __("no data.", "post-worktime-logger");
| } | ||
|
|
||
| echo '<div class="wrap">'; | ||
| echo '<h1>Post Worktime Logger - Statistics</h1>'; |
| } | ||
|
|
||
| // Register menu entry for pwlStatsPage | ||
| add_action( 'admin_menu', function(){ |
There was a problem hiding this comment.
I will fix this, so it fits with my settings page menu options, which I will implement in v1.3.0 (Remember, this feature is planned for v1.4.0)
There was a problem hiding this comment.
Forget it with v1.3.0 and v1.4.0.
This feature will also available in v1.3.0
| // Register menu entry for pwlStatsPage | ||
| add_action( 'admin_menu', function(){ | ||
| //TODO: this is a submenu of plugins but doesnt quite make sense...better move it to a separate menu | ||
| add_submenu_page( 'plugins.php', 'pwlStats', 'pwl-Statistics', 'manage_options', 'pwlStats', 'pwlStatsPage' ); |
| data: { | ||
| labels: ['" . implode('\', \'', $posts_titles) . "'], | ||
| datasets: [{ | ||
| label: 'worktime in seconds', |
|
|
||
| foreach($tPosts as $tPost){ | ||
| $posts_titles[] = $tPost->post_title; | ||
| $posts_worktimes[] = get_post_meta($tPost->ID, "post-worktime", true); |
There was a problem hiding this comment.
Maybe you should use round($worktime/3600, 0), so we have the hours instead of the seconds.
|
|
||
| echo "<script> | ||
| var ctx = document.getElementById('pwlTopFiveWorktimePosts'); | ||
| var pwlTopFiveWorktimePosts = new Chart(ctx, { |
There was a problem hiding this comment.
Is there a way, to make the bars a little bit thinner?
|
I have created a new pull request with the fixes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add statistics page with top25 posts (worktime)
add new resource: minified Chart.js