Refactor component registration

blade-ui-kit · Jun 27, 2020 · e7c20c7 · e7c20c7
1 parent 8721ea6
commit e7c20c7
Show file tree

Hide file tree

Showing 3 changed files with 22 additions and 12 deletions.
diff --git a/src/BladeIconsServiceProvider.php b/src/BladeIconsServiceProvider.php
@@ -19,6 +19,7 @@ public function register(): void
 
     public function boot(): void
     {
+        $this->bootComponents();
         $this->bootDirectives();
         $this->bootPublishing();
     }
@@ -45,6 +46,13 @@ private function registerFactory(): void
         });
     }
 
+    private function bootComponents(): void
+    {
+        $this->callAfterResolving('view', function ($view, Application $app) {
+            $app->make(Factory::class)->registerComponents();
+        });
+    }
+
     private function bootDirectives(): void
     {
         Blade::directive('svg', function ($expression) {

diff --git a/src/Factory.php b/src/Factory.php
@@ -60,23 +60,23 @@ public function add(string $set, array $options): self
 
         $this->sets[$set] = $options;
 
-        $this->registerComponents($options);
-
         $this->cache = [];
 
         return $this;
     }
 
-    private function registerComponents(array $options): void
+    public function registerComponents(): void
     {
-        foreach ($this->filesystem->allFiles($options['path']) as $file) {
-            $path = array_filter(explode('/', Str::after($file->getPath(), $options['path'])));
-
-            Blade::component(
-                SvgComponent::class,
-                implode('.', array_filter($path + [$file->getFilenameWithoutExtension()])),
-                $options['prefix']
-            );
+        foreach ($this->sets as $set) {
+            foreach ($this->filesystem->allFiles($set['path']) as $file) {
+                $path = array_filter(explode('/', Str::after($file->getPath(), $set['path'])));
+
+                Blade::component(
+                    SvgComponent::class,
+                    implode('.', array_filter($path + [$file->getFilenameWithoutExtension()])),
+                    $set['prefix']
+                );
+            }
         }
     }
 

diff --git a/tests/ComponentsTest.php b/tests/ComponentsTest.php
@@ -13,7 +13,9 @@ class ComponentsTest extends TestCase
     /** @test */
     public function components_are_registered_with_their_subdirectories()
     {
-        $this->prepareSets();
+        $factory = $this->prepareSets();
+
+        $factory->registerComponents();
 
         $this->assertSame([
             'icon-camera' => Svg::class,