Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Git submodules for OAuth #1

Merged
merged 2 commits into from Mar 24, 2015
Merged

Conversation

pselle
Copy link
Contributor

@pselle pselle commented Mar 24, 2015

Hey! You should test this out but I think it helps :)

When cloning this app, it doesn't have OAuthClient, but using .gitmodules to manage it should make future clone-ers download a runnable source.

bladeofky added a commit that referenced this pull request Mar 24, 2015
@bladeofky bladeofky merged commit 55fff4b into bladeofky:master Mar 24, 2015
@bladeofky
Copy link
Owner

Cool, thanks!

@pselle
Copy link
Contributor Author

pselle commented Mar 24, 2015

\o/

@bladeofky
Copy link
Owner

I actually didn't test it because I know next to nothing about git, but I'm sure it works haha

@pselle
Copy link
Contributor Author

pselle commented Mar 24, 2015

Ha, thanks! We were working on a similar app (building in a different platform to play with that) last night at HS hack night and ended up checking out your proj. It's really nice!

@bladeofky
Copy link
Owner

haha thanks. If only I could get Apple to take it. I stripped out most of the options that weren't optimized for mobile. My only problem now is managing the cookies on WKWebview. Currently there's no good way to do it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants