Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Compare shopping list to pantry #35

Closed
9 tasks done
blahosyl opened this issue Apr 16, 2024 · 1 comment · Fixed by #43
Closed
9 tasks done

Compare shopping list to pantry #35

blahosyl opened this issue Apr 16, 2024 · 1 comment · Fixed by #43
Assignees
@blahosyl
Labels
enhancement New feature or request optional Outside the scope of the MVP

Comments

@blahosyl
Copy link
Owner

blahosyl commented Apr 16, 2024 •
edited
Loading

User goal: adjust the shopping list based on the ingredients already available

Possible implementation:

  • At the end of the program, before the goodbye screen, ask user if they want to compare shopping list to pantry
    • validate answer (Y/N)
  • loop through each ingredient, and ask how much they have
    • can only enter a float (can use a similar validation as for dish selection)
    • subtract entered number from quantity on shopping list
    • if shopping list quantity <= zero, delete item from shopping list
  • print revised shopping list
  • make new function a method of the ShoppingList object
  • integrate new function into existing flow
@blahosyl blahosyl added enhancement New feature or request optional Outside the scope of the MVP labels Apr 16, 2024
@blahosyl blahosyl self-assigned this Apr 16, 2024
blahosyl added a commit that referenced this issue Apr 16, 2024
@blahosyl
start basics of pantry function #35
07c26af
blahosyl added a commit that referenced this issue Apr 16, 2024
@blahosyl
delete items in the pantry from shopping list #35
754d207 
after checking with the pantry, only items with a quantity of more than 0 should remain on the shopping list
blahosyl added a commit that referenced this issue Apr 16, 2024
@blahosyl
add study credits #4 #35
62e5665
blahosyl added a commit that referenced this issue Apr 16, 2024
@blahosyl
add study credit #4 #35
14caca6
blahosyl added a commit that referenced this issue Apr 17, 2024
@blahosyl
make upper limit of range validator optional #42 #35
7e9ed34
blahosyl added a commit that referenced this issue Apr 17, 2024
@blahosyl
connect planner to pantry #35
e8edcbc
blahosyl added a commit that referenced this issue Apr 17, 2024
@blahosyl
use range validator w unbounded floats #42 #35
7b3b5ee
@blahosyl blahosyl mentioned this issue Apr 17, 2024
Merged
@blahosyl blahosyl linked a pull request Apr 17, 2024 that will close this issue
Improve range checker & start "check pantry" logic #43
Merged
blahosyl added a commit that referenced this issue Apr 17, 2024
@blahosyl
use ShoppingList print method for pantry list #35
a9c7f89
blahosyl added a commit that referenced this issue Apr 17, 2024
@blahosyl
make print_formatted() independent #35
cc53a82 
move outside the scope of `ShoppingList`
blahosyl added a commit that referenced this issue Apr 17, 2024
@blahosyl
move singularization logic to print_formatted#35
3083ad8
blahosyl added a commit that referenced this issue Apr 17, 2024
@blahosyl
finish developing pantry function #35
2c49b86
blahosyl added a commit that referenced this issue Apr 18, 2024
@blahosyl
integrate check_pantry into main flow #35
37ee92d
blahosyl added a commit that referenced this issue Apr 18, 2024
@blahosyl
remove BRIGHT from check_pantry #35
ad0f699
blahosyl added a commit that referenced this issue Apr 18, 2024
@blahosyl
convert check_pantry to ShoppingList method #35
9c568d7
blahosyl added a commit that referenced this issue Apr 18, 2024
@blahosyl
delete pantry.py from repo #35
8269056
blahosyl added a commit that referenced this issue Apr 18, 2024
@blahosyl
remove pantry import code #35
4fce14c
blahosyl added a commit that referenced this issue Apr 18, 2024
@blahosyl
add confirmation msg to check_pantry() #35
277153c
blahosyl added a commit that referenced this issue Apr 18, 2024
@blahosyl
remove line bread before pantry item check #35 #21
5d7899a
blahosyl added a commit that referenced this issue Apr 18, 2024
@blahosyl
fix display of pantry prompt #35 #21
25ae1f4
@blahosyl blahosyl reopened this Apr 18, 2024
@blahosyl
Copy link
Owner Author

Add logic for case where all ingredients are in the pantry, so shopping list becomes empty

blahosyl added a commit that referenced this issue Apr 18, 2024
@blahosyl
improve check_pantry UX #35 #21
23adfd6
blahosyl added a commit that referenced this issue Apr 18, 2024
@blahosyl
add logic for when shopping list is empty #35
684a08a 
this happens when all ingredients are in the pantry in sufficient quentities
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@blahosyl blahosyl

Labels
enhancement New feature or request optional Outside the scope of the MVP
Projects
Dinner Party Planner
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Improve range checker & start "check pantry" logic blahosyl/dinner-party
1 participant
@blahosyl