Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Position of small button on Welcome screen is not the same for score-div and gameplay-rules-div #36

Closed
blahosyl opened this issue Mar 28, 2024 · 2 comments
Closed

Position of small button on Welcome screen is not the same for score-div and gameplay-rules-div #36

blahosyl opened this issue Mar 28, 2024 · 2 comments
Assignees
@blahosyl
Labels
bug Something isn't working

Comments

@blahosyl
Copy link
Owner

blahosyl commented Mar 28, 2024 •
edited
Loading

There is some extra space below the score-button margin and the bottom of the parent div in gameplay-rules-div, but not so for gameplay-rules-button in score-div.

The 2 parent divs have the same styling (except for display: none vs. display: flex, so what is causing the difference?
@blahosyl blahosyl added the bug Something isn't working label Mar 28, 2024
@blahosyl blahosyl self-assigned this Mar 28, 2024
blahosyl added a commit that referenced this issue Mar 28, 2024
@blahosyl
add screenshots for button position #36
1ed3a9c
@blahosyl
Copy link
Owner Author

Bug implementing #21

blahosyl added a commit that referenced this issue Mar 28, 2024
@blahosyl
fix small button placement in Weclome screen #36
ce84fe2
@blahosyl
Copy link
Owner Author

Issue was caused by the score-button being placed inside a p, while the gameplay-rules-button wasn't

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@blahosyl blahosyl

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@blahosyl