Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] test switching from build.ps1 to build.cmd to solve #60 #62

Closed
wants to merge 2 commits into from
Closed

[WIP] test switching from build.ps1 to build.cmd to solve #60 #62

wants to merge 2 commits into from

Conversation

adamralph
Copy link
Collaborator

Connects to #60.

@adamralph adamralph changed the title Test 60 cmd switch from build.ps1 to build.cmd Sep 2, 2018
@adamralph
Copy link
Collaborator Author

adamralph commented Sep 2, 2018

The build fails, and is reported as failure: https://ci.appveyor.com/project/blairconrad/selfinitializingfakes/build/85-gclbjcbi

@blairconrad it looks like the use of build.ps1 rather than build.cmd is problematic.

@adamralph adamralph changed the title switch from build.ps1 to build.cmd [WIP] test the switch from build.ps1 to build.cmd Sep 2, 2018
@adamralph adamralph changed the title [WIP] test the switch from build.ps1 to build.cmd [WIP] test switching from build.ps1 to build.cmd to solve #60 Sep 2, 2018
Copy link
Owner

@blairconrad blairconrad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @adamralph. It'd be nice to stick with a ps1, but that seems fraught, and I don't mind so much switching to cmd. I'd ask that you remove the bad package and update the how_to_build and we're off to the races.

@adamralph
Copy link
Collaborator Author

@blairconrad before doing that, I'd like understand what is wrong with using build.ps1 and whether there is a way to fix it. Reason being, I provide a sample build.ps1 in Bullseye, and I know of at least one other project which uses it.

@adamralph
Copy link
Collaborator Author

@blairconrad I've raised #65 to fix #60, and I've raised adamralph/bullseye#83 to look into the ps1 problem.

@adamralph adamralph closed this Sep 6, 2018
@adamralph adamralph deleted the test-60-cmd branch September 6, 2018 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants