Update framework and FakeItEasy support #89
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blairconrad
changed the title
blairconrad
force-pushed
the
update-post-FakeItEasy-7.0.0
branch
from
68adf40
to
1aea2ac
Compare
blairconrad
force-pushed
the
update-post-FakeItEasy-7.0.0
branch
from
1aea2ac
to
97c8711
Compare
|
Ha, @thomaslevesque. I just realized I had this hanging around from nigh 36 months ago! |
| @@ -1,6 +1,6 @@ | |||
| [assembly: System.Runtime.InteropServices.ComVisible(false)] | |||
| [assembly: System.Runtime.InteropServices.Guid("08462e29-25c0-4a1f-9275-23b7898e95f0")] | |||
| [assembly: System.Runtime.Versioning.TargetFramework(".NETStandard,Version=v1.6", FrameworkDisplayName="")] | |||
| [assembly: System.Runtime.Versioning.TargetFramework(".NETStandard,Version=v5.0", FrameworkDisplayName="")] | |||
There was a problem hiding this comment.
I realize you didn't manually write this, but... .NET Standard 5.0? I don't think this target framework exists!
There was a problem hiding this comment.
Who knows. Maybe I did write it. Maybe I just copied the file and changed the version number! I might do that. FakeItEasy has
.NETCoreApp,Version=v5.0
And... I can't run the Api tests locally! They hang! But not for FakeItEasy…
There was a problem hiding this comment.
That's weird... but they run on AppVeyor? They should have failed, then, shouldn't they? Since the received and approved files would have been different...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.