Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docker version #55

Closed
Githeo opened this issue Oct 1, 2022 · 16 comments
Closed

Docker version #55

Githeo opened this issue Oct 1, 2022 · 16 comments
Assignees
Labels
help wanted Extra attention is needed

Comments

@Githeo
Copy link

Githeo commented Oct 1, 2022

Hi,
is there a specific requirement on the docker version?
Docker version 2.3.0.5 (I know quite old but is the one for high sierra) seems not to be recognized:

Screen Shot 2022-10-01 at 16 04 53

Thank you.

@Githeo Githeo added the help wanted Extra attention is needed label Oct 1, 2022
@damt983
Copy link

damt983 commented Dec 27, 2022

Same happends to me

@hithisisfun
Copy link

did there end up being a way of solving this, the same happens to me.

@edudediegolucas
Copy link

edudediegolucas commented Apr 10, 2023

Same for BigSur:
imagen

Using

$ docker --version
Docker version 20.10.24, build 297e128

and ace-link app version 2.0.2.

@viktordavidovich
Copy link

Same for me, docker version is 20.10.24

@blaise-io
Copy link
Owner

I'm likely detecting whether Docker is installed the wrong way. (

let canPlay = Process.runCommand("docker").terminationStatus == 0
) I did this to support Colima, which is a Docker replacement, instead of detecting a correct BundleID but apparently running docker without parameters may exit with an error status.

@blaise-io
Copy link
Owner

blaise-io commented Apr 12, 2023

@edudediegolucas @viktordavidovich what do you get for docker; echo $?; which docker?

@blaise-io
Copy link
Owner

blaise-io commented Apr 12, 2023

Alternatively, does this work for you guys? Ace.Link.2.0.3-RC.dmg.zip

@viktordavidovich
Copy link

@edudediegolucas @viktordavidovich what do you get for docker; echo $?; which docker?

@blaise-io I'm getting this /usr/local/bin/docker
Long story short, I had to uninstall docker which has been already installed before ace-link. I've done the same for VLC player (has been installed before)
Then I called brew install ace-link --cask and now ace-link works fine.

@blaise-io
Copy link
Owner

blaise-io commented Apr 12, 2023

Thanks @viktordavidovich.

I created https://github.com/blaise-io/acelink/releases/download/2.0.3/Ace.Link.2.0.3.dmg which slightly changes the detection of docker. If anyone still has issues, please open Terminal.app and report your output of docker; echo $?; docker --version; echo $?; which docker

@edudediegolucas
Copy link

edudediegolucas commented Apr 12, 2023

@edudediegolucas @viktordavidovich what do you get for docker; echo $?; which docker?

@blaise-io this where my docker is (I installed via brew long time ago):

/Applications/Docker.app/Contents/Resources/bin/docker

Recently, I had to change my PATH env to apps folder because latest docker versions provided the possibility of having binaries in non-sudo folders: I noticed also that when upgrading via brew, it does not ask for sudo password anymore.

And I have updated as well the app to the new 2.0.3 version I have still the Docker is required... message.

Thanks for your time, really appreciated.

@blaise-io
Copy link
Owner

I can solve this but it gets a bit ugly: I can find and run Docker by BundleID, but Ace Link also sort of supports Colima and possibly other runtimes in the future, so then I'd have to list those BundleID's as well. But I don't know which BundleID would be preferred by the user, so then it gets messy. It's probably best to rely for now on the docker that's on the PATH.

@marcosdiak
Copy link

@edudediegolucas @viktordavidovich what do you get for docker; echo $?; which docker?

@blaise-io I'm getting this /usr/local/bin/docker Long story short, I had to uninstall docker which has been already installed before ace-link. I've done the same for VLC player (has been installed before) Then I called brew install ace-link --cask and now ace-link works fine.

This worked for me too. Thanks.

@josephxk
Copy link

This happened for me too, Docker version 20.10.24 and Ace link 2.05, on an M1.
When I first installed Docker, the CLI tools were installed under ~/.docker/bin and Ace link could not detect Docker. Going into Docker's settings > advanced and changing the location of the CLI tools to /usr/local/bin fixed it for me.

How about adding ~/.docker/bin to the PATH in the detection process?

@blaise-io
Copy link
Owner

For those who don't have docker in their path, can you verify this build works? Ace.Link.2.0.5-bundleid.dmg.zip

If it does not work, please paste the log of Ace Link in this issue. You can retrieve the log like this:

  1. Open Console.app
  2. In Console.app search box, type Process: Ace Link and press enter
  3. Click on Start or Start streaming
  4. Open this Ace Link build
  5. It should now start populating Console.app with debug information, Cmd+A, Cmd+C and then Cmd+V in this issue

@edudediegolucas
Copy link

Hey @blaise-io , I finally have Ace Link working ;)
I did 2 main things, first, change docker location here:

imagen

and secondly, working with IntelliJ and docker gave me another hint (honestly don't know if this was the issue):

imagen

I simply symlinked my home docker.sock to the one in /var/run via sudo.

Anyway, IMO, the first option is more suitable to be the solution to my problem but I put the second if anyone has any other related issue.
Thanks for the help!

@blaise-io
Copy link
Owner

Thanks @edudediegolucas, I'm glad you got it working :)

For those who still having issues finding Docker, please try #55 (comment), because it attempts to find the docker cli inside Docker.app.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

8 participants