-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add all
object sensor to camera and zone devices
#224
Add all
object sensor to camera and zone devices
#224
Conversation
Codecov Report
@@ Coverage Diff @@
## master #224 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 10 10
Lines 1278 1286 +8
=========================================
+ Hits 1278 1286 +8
Continue to review full report at Codecov.
|
Would you mind adding a test that verifies that the entity is not present at first, then is present when enabled? For inspiration, see: https://github.com/dermotduffy/hass-core/blob/dev/tests/components/hyperion/test_switch.py#L187 Key bit: updated_entry = entity_registry.async_update_entity(
entity_id, disabled_by=None
) Otherwise, looks great to me. In terms of merging, I'd suggest we wait until blakeblackshear/frigate#2908 is in, just in case there is feedback upstream. |
@dermotduffy Let me know what you think of the tests I added. And yeah I agree will want to wait until frigate PR is merged 👍 |
@NickM-27 Looking good! Minor typo. |
@dermotduffy The upstream frigate PR was just merged |
Thanks for the great work @NickM-27 ! |
all
object sensor to camera and zone devicesall
object sensor to camera and zone devices
Fix for #161
Related frigate PR: blakeblackshear/frigate#2908