Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue with superfluous 'all' sensor being created #227

Merged
merged 2 commits into from
Mar 11, 2022

Conversation

NickM-27
Copy link
Sponsor Collaborator

The all part was working except it was creating a camera.office_all for example which it shouldn't

@codecov
Copy link

codecov bot commented Mar 11, 2022

Codecov Report

Merging #227 (5568033) into master (400ab71) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #227   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           10        10           
  Lines         1302      1303    +1     
=========================================
+ Hits          1302      1303    +1     
Impacted Files Coverage Δ
custom_components/frigate/camera.py 100.00% <ø> (ø)
custom_components/frigate/__init__.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 400ab71...5568033. Read the comment docs.

@dermotduffy dermotduffy merged commit c3083f7 into blakeblackshear:master Mar 11, 2022
@NickM-27 NickM-27 deleted the filter-all-cam branch March 11, 2022 18:48
@dermotduffy dermotduffy added the bug Something isn't working label Apr 5, 2022
@dermotduffy dermotduffy changed the title Filter all cam Fix issue with superfluous 'all' sensor being created Apr 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants