Add support for motion detection switch #241
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #241 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 11 11
Lines 1373 1373
=========================================
Hits 1373 1373
Continue to review full report at Codecov.
|
|
As long as we are handling the state topic correctly in frigate, I think it will just toggle back to on by itself. |
…gration into motion-switch
|
This looks good to me (awaiting parent PR to be merged). |
…gration into motion-switch
|
@dermotduffy parent PR has been merged 👍 |
…gration into motion-switch
|
Thanks @NickM-27 ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for blakeblackshear/frigate#3117
Concerns
Only concern is the req
motion detection toggle to off will fail if detect is enabled. Assuming this req is what is merged, if in HA we call publish motion OFF and it fails on frigate side, will the switch here get set back to the correct state or will it show OFF incorrectly?Basically: do we need to implement this restriction here as well?