Ability to disable media browser

[NickM-27]

Fix for #218

[codecov]

Codecov Report

Merging #262 (f926c2a) into master (6df9ee5) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##            master      #262   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           12        12           
  Lines         1438      1445    +7     
=========================================
+ Hits          1438      1445    +7     

Impacted Files	Coverage Δ
custom_components/frigate/config_flow.py	100.00% <ø> (ø)
custom_components/frigate/const.py	100.00% <100.00%> (ø)
custom_components/frigate/media_source.py	100.00% <100.00%> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6df9ee5...f926c2a. Read the comment docs.

[NickM-27]

[dermotduffy]

[With apologies in advance for re-thinking this] I think I have a much better idea. Leave this method the way it used to be, and check the option in FrigateMediaSource.

Suggestion on how to do this (pardon the verbosity as this file is quite complex). You'll need to add a new method such as _isAllowedAsMediaSource that takes a frigate_instance_id and returns True if for that instance_id, in the config entry (which can you get by calling get_config_entry_for_frigate_instance_id) the option is set correctly.

Then call that verification method in these places (in all cases you can get the frigate_instance_id from the identifer as identifier.frigate_instance_id).

• async_resolve_media [here]
• async_browse_media [here]
• async_browse_media [here]

This is much better because if I have 3 Frigate instances, and I disable the media for 1 of them, media will still work as usual for the other 2 rather than 'all or nothing'.

[NickM-27]

No problem, that's a much better solution, will jump on that tomorrow.

The test will probably need to be tweaked as well

[NickM-27]

Not sure why HACS is failing. I am seeing that on my integration as well but unfortunately not seeing much help with what changes are actually needed.

[dermotduffy]

Not sure. This in the build logs (but you didn't change the manifest):

  Error:  <Validation hacs_manifest> failed:  extra keys not allowed @ data['domains']
  Error:  <Integration blakeblackshear/frigate-hass-integration> 1/5 checks failed
  Error: HACS load check

What happens when you load the integration?

[Vaskivskyi]

Not sure why HACS is failing. I am seeing that on my integration as well but unfortunately not seeing much help with what changes are actually needed.

This happens to all the integration, that are still using hacs.json values, which are not supported anymore. Not connected to this PR, but to the HACS itself. #263 will fix it (checked on my HA integration recently)

[NickM-27]

Seems the check is further up stream and the lower stream exception doesn't get tested, not really sure of a good way to test that unless it is called directly

[NickM-27]

@dermotduffy Thank you!