Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow favorite_event to be configured from UI #301

Merged
merged 2 commits into from Jul 6, 2022

Conversation

felipecrs
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented Jul 5, 2022

Codecov Report

Merging #301 (69351b3) into master (9bbcbdd) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##            master      #301   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           13        13           
  Lines         1557      1552    -5     
=========================================
- Hits          1557      1552    -5     
Impacted Files Coverage Δ
custom_components/frigate/camera.py 100.00% <100.00%> (ø)
custom_components/frigate/const.py 100.00% <100.00%> (ø)
custom_components/frigate/views.py 100.00% <0.00%> (ø)
custom_components/frigate/__init__.py 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9bbcbdd...69351b3. Read the comment docs.

@felipecrs
Copy link
Contributor Author

I believe it is worth mentioning that regular camera entities will now have the attribute device_class=camera (and that motion camera entities already had device_class=motion).

This could be useful for blueprints, like the famous Frigate Mobile App Notifications for filtering out the motion camera entities when selecting.

@dermotduffy dermotduffy added the enhancement New feature or request label Jul 6, 2022
@dermotduffy
Copy link
Collaborator

FYI: @NickM-27 also.

Thanks @felipecrs !

@dermotduffy dermotduffy merged commit b81d132 into blakeblackshear:master Jul 6, 2022
@felipecrs felipecrs deleted the improve-service branch July 6, 2022 02:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants