Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FEAT: Allow threshold and contour_area to be set from Home Assistant #316

Merged
merged 37 commits into from Jul 22, 2022
Merged

FEAT: Allow threshold and contour_area to be set from Home Assistant #316

merged 37 commits into from Jul 22, 2022

Conversation

NickM-27
Copy link
Sponsor Collaborator

No description provided.

@codecov
Copy link

codecov bot commented Jul 20, 2022 •
edited

Codecov Report

Merging #316 (ed4302f) into master (8d1bdd7) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##            master      #316   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           13        14    +1     
  Lines         1578      1669   +91     
=========================================
+ Hits          1578      1669   +91
Impacted Files Coverage Δ
custom_components/frigate/const.py 100.00% <100.00%> (ø)
custom_components/frigate/number.py 100.00% <100.00%> (ø)
custom_components/frigate/sensor.py 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8d1bdd7...ed4302f. Read the comment docs.

@NickM-27 NickM-27 marked this pull request as ready for review July 20, 2022 17:08
@dermotduffy dermotduffy added the enhancement New feature or request label Jul 21, 2022
dermotduffy
dermotduffy reviewed Jul 21, 2022
View reviewed changes
Copy link
Collaborator

@dermotduffy dermotduffy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great new feature!

custom_components/frigate/number.py Outdated Show resolved Hide resolved
custom_components/frigate/number.py Outdated Show resolved Hide resolved
custom_components/frigate/number.py Outdated Show resolved Hide resolved
custom_components/frigate/number.py Show resolved Hide resolved
custom_components/frigate/number.py Outdated Show resolved Hide resolved
custom_components/frigate/number.py Show resolved Hide resolved
tests/test_number.py Show resolved Hide resolved
tests/test_number.py Show resolved Hide resolved
tests/test_number.py Show resolved Hide resolved
tests/test_number.py Outdated Show resolved Hide resolved
@dermotduffy dermotduffy changed the title FEAT: Number entities for threshold and contour_area FEAT: Allow threshold and contour_area to be set from Home Assistant Jul 21, 2022
NickM-27 and others added 12 commits July 21, 2022 09:56
@NickM-27
Update comment
2b6545d
@NickM-27
Don't catch write
898431a
@NickM-27
Use attr not properties
273f15a
@NickM-27 @dermotduffy
Improve class comment
852cae3 
Co-authored-by: Dermot Duffy <dermot.duffy@gmail.com>
@NickM-27
Fix service comments
4215e6a
@NickM-27 @dermotduffy
Update class comment
f09a714 
Co-authored-by: Dermot Duffy <dermot.duffy@gmail.com>
@NickM-27
Don't catch ha write
4e1f4d9
@NickM-27 @dermotduffy
Update custom_components/frigate/number.py
60b4353 
Co-authored-by: Dermot Duffy <dermot.duffy@gmail.com>
@NickM-27
Test both unique IDs
d1fc41b
@NickM-27 @dermotduffy
Fix typo
b39aa5c 
Co-authored-by: Dermot Duffy <dermot.duffy@gmail.com>
@NickM-27
Merge branch 'camera-motion-tuning' of github.com:NickM-27/frigate-ha…
b2dde33 
…ss-integration into camera-motion-tuning
@NickM-27
Fix template
ed4302f
@dermotduffy dermotduffy merged commit 7738c09 into blakeblackshear:master Jul 22, 2022
@dermotduffy
Copy link
Collaborator

Thanks @NickM-27 !

@NickM-27 NickM-27 deleted the camera-motion-tuning branch July 22, 2022 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dermotduffy dermotduffy dermotduffy left review comments

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@NickM-27 @dermotduffy