Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support dynamic icons for binary sensors #336

Merged
merged 11 commits into from Sep 16, 2022
Merged

Support dynamic icons for binary sensors #336

merged 11 commits into from Sep 16, 2022

Conversation

NickM-27
Copy link
Sponsor Collaborator

Implementation of #318

@codecov
Copy link

codecov bot commented Sep 14, 2022 •
edited

Codecov Report

Merging #336 (779deef) into master (1c96743) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##            master      #336   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           14        15    +1     
  Lines         1712      1733   +21     
=========================================
+ Hits          1712      1733   +21
Impacted Files Coverage Δ
custom_components/frigate/const.py 100.00% <ø> (ø)
custom_components/frigate/binary_sensor.py 100.00% <100.00%> (ø)
custom_components/frigate/icons.py 100.00% <100.00%> (ø)
custom_components/frigate/number.py 100.00% <100.00%> (ø)
custom_components/frigate/sensor.py 100.00% <100.00%> (ø)
custom_components/frigate/switch.py 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@NickM-27 NickM-27 marked this pull request as ready for review September 14, 2022 21:08
@NickM-27
Copy link
Sponsor Collaborator Author

@dermotduffy Ready for review 👍

@dermotduffy dermotduffy changed the title Move icons to own module and support dynamic icons for binary sensors Support dynamic icons for binary sensors Sep 15, 2022
@dermotduffy dermotduffy added the enhancement New feature or request label Sep 15, 2022
dermotduffy
dermotduffy requested changes Sep 15, 2022
View reviewed changes
Copy link
Collaborator

@dermotduffy dermotduffy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @NickM-27 ! Minor changes requested.

NickM-27 and others added 5 commits September 15, 2022 06:26
@NickM-27 @dermotduffy
Cleanup return
10d1404 
Co-authored-by: Dermot Duffy <dermot.duffy@gmail.com>
@NickM-27 @dermotduffy
Cleanup return
36fb522 
Co-authored-by: Dermot Duffy <dermot.duffy@gmail.com>
@NickM-27 @dermotduffy
Cleanup return
3934cb8 
Co-authored-by: Dermot Duffy <dermot.duffy@gmail.com>
@NickM-27
Remove odd boolean type
9f854a0
@NickM-27
Fix indentation
779deef
@dermotduffy dermotduffy merged commit 387af4d into blakeblackshear:master Sep 16, 2022
@dermotduffy
Copy link
Collaborator

Thank you @NickM-27 !

@NickM-27 NickM-27 deleted the binary-sensor-icons branch August 13, 2023 02:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dermotduffy dermotduffy Awaiting requested review from dermotduffy

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@NickM-27 @dermotduffy