Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support proxy view for preview gifs #664

Merged
merged 5 commits into from
May 11, 2024
Merged

Support proxy view for preview gifs #664

merged 5 commits into from
May 11, 2024

Conversation

NickM-27
Copy link
Sponsor Collaborator

No description provided.

@NickM-27 NickM-27 force-pushed the gif-notification branch 2 times, most recently from 200b633 to 086143c Compare April 18, 2024 20:48
@NickM-27
Copy link
Sponsor Collaborator Author

Might need some help with this, works on my live instance but for some reason it says that it doesn't work here

@kirsch33
Copy link

kirsch33 commented May 1, 2024

@NickM-27
i think its because for some reason the /review/<id>/preview.gif endpoint is missing the .gif part on the main Frigate repo:

https://github.com/blakeblackshear/frigate/blob/2e639415987ca3eb546aed842f06eef691636d8e/frigate/api/media.py#L1336

if i remove .gif from your code above it works

@NickM-27
Copy link
Sponsor Collaborator Author

NickM-27 commented May 1, 2024

@kirsch33 the tests here have no knowledge of frigate code. Them failing is not directly related to it actually working in frigate or not

@kirsch33
Copy link

kirsch33 commented May 1, 2024

understood, regardless when I implemented this on my own it was not working without removing .gif so just wanted to mention it

@NickM-27
Copy link
Sponsor Collaborator Author

NickM-27 commented May 1, 2024

yeah this PR is outdated since I implemented it

@NickM-27
Copy link
Sponsor Collaborator Author

@dermotduffy can you take a look at this if you have a minute? I am at a loss as to why 500 is occurring when it works in actual usage

@dermotduffy
Copy link
Collaborator

@NickM-27 Had a shot. Note that I don't know what the real backend paths are, so you'll have to sanity check/edit my changes.

PS: You may kick yourself :-)

@dermotduffy dermotduffy added the enhancement New feature or request label May 11, 2024
@NickM-27
Copy link
Sponsor Collaborator Author

I see vs code wasn't warning me of my silly mistake. 😂

@dermotduffy
Copy link
Collaborator

@NickM-27 LGTM. I think we probably want this on dev?

@NickM-27 NickM-27 changed the base branch from master to dev May 11, 2024 23:44
@NickM-27
Copy link
Sponsor Collaborator Author

Oops yep, updated

@NickM-27 NickM-27 merged commit 49c9a0f into dev May 11, 2024
4 checks passed
@NickM-27 NickM-27 deleted the gif-notification branch May 11, 2024 23:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants