-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support proxy view for preview gifs #664
Conversation
200b633
to
086143c
Compare
Might need some help with this, works on my live instance but for some reason it says that it doesn't work here |
@NickM-27 if i remove |
@kirsch33 the tests here have no knowledge of frigate code. Them failing is not directly related to it actually working in frigate or not |
understood, regardless when I implemented this on my own it was not working without removing |
yeah this PR is outdated since I implemented it |
@dermotduffy can you take a look at this if you have a minute? I am at a loss as to why 500 is occurring when it works in actual usage |
@NickM-27 Had a shot. Note that I don't know what the real backend paths are, so you'll have to sanity check/edit my changes. PS: You may kick yourself :-) |
I see vs code wasn't warning me of my silly mistake. 😂 |
b71335e
to
b03742c
Compare
b03742c
to
b6f80e4
Compare
@NickM-27 LGTM. I think we probably want this on |
Oops yep, updated |
No description provided.