Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate helm chart #156

Closed
billimek opened this issue Jul 7, 2020 · 11 comments · Fixed by blakeblackshear/blakeshome-charts#3
Closed

Migrate helm chart #156

billimek opened this issue Jul 7, 2020 · 11 comments · Fixed by blakeblackshear/blakeshome-charts#3

Comments

@billimek
Copy link
Contributor

billimek commented Jul 7, 2020

We discussed this in a PR for the frigate helm chart over in the billimek-charts repo. I'd like to start the process to 'move' the chart over here.

Would you prefer it to be added within this repo, or a separate (dedicated?) repo? I beleive either should work fine. It's best (IMO) to have it within a charts subdirectory and there are excellent github actions for auto linting/testing (although automated testing the frigate installation is tricky at the moment) and releasing the chart.
@blakeblackshear
Copy link
Owner

If you recommend adding to a charts directory in this repo, that is fine. I do have some other charts I will end up creating too, so whatever you recommend based on your experience is fine.

@blakeblackshear blakeblackshear added this to v0.9.0 - Better Homeassistant Integration in Core Sep 11, 2020
@billimek
Copy link
Contributor Author

billimek commented Oct 9, 2020 •
edited
Loading

The chart linting/testing/releasing automation I suggest using does create github 'releases' for each chart release. Based on this, and that you may have additional charts, I think a dedicated charts repo (maybe blakeblackshear/frigate ?) would make more sense.

Happy to start the migration process whenever it makes the most sense for you!

@blakeblackshear
Copy link
Owner

Agreed. I will create a dedicated repo for helm charts soon.

@blakeblackshear
Copy link
Owner

I created a repo here: https://github.com/blakeblackshear/blakeshome-charts

Appreciate the assist.

@billimek billimek mentioned this issue Oct 18, 2020
Closed
@brujoand
Copy link

brujoand commented Dec 9, 2020

Maybe this could add support for exposing port 1935 also when migrating?

@blakeblackshear
Copy link
Owner

This is a bit messy at the moment. I have updated the helm chart here, but haven't moved things over. https://github.com/blakeblackshear/billimek-charts/tree/master/charts/frigate

@billimek
Copy link
Contributor Author

billimek commented Dec 9, 2020

It's on my list of things to do for formally migrating the frigate chart over here, sorry for the delays!

@blakeblackshear blakeblackshear moved this from v0.8.0 - Better Homeassistant Integration to v0.9.0 - Custom Model Training in Core Jan 19, 2021
@billimek billimek mentioned this issue Jan 23, 2021
Closed
4 tasks
@billimek
Copy link
Contributor Author

@blakeblackshear I'd like to take a stab at the chart migration this weekend. The https://github.com/blakeblackshear/blakeshome-charts repo is empty and I can't fork to PR the incomgin chart.

  • Do you still want to use that repo to host the chart? (I do strongly suggest leveraging a dedicated repo for chart(s) instead of co-habbing with the frigate repo so there won't be tagging confusion.
  • If so, can you push something to the repo so it can be forked?
  • Alternatively, if you add me as a contributor to https://github.com/blakeblackshear/blakeshome-charts I can branch directly and PR the incomnig chart and associated actions changes.

@blakeblackshear
Copy link
Owner

I pushed up a commit. Appreciate the help.

@brujoand
Copy link

@billimek I'll just close my PR on the k8s-at-home repo then and you'll add the port and volume when migrating?

@billimek
Copy link
Contributor Author

@brujoand yes, will do!

This was referenced Jan 30, 2021
Merged
Merged
luoj1 pushed a commit to luoj1/frigate that referenced this issue Apr 29, 2023
@xzdandy @gaurav274
coalesce to improve writing speed. (blakeblackshear#166)
7b808d9 
Use coalesce in pyspark to improve writing speed (blakeblackshear#156). Can be configured in eva.yml.

Issue:
Skip test_select_and_sample in https://github.com/georgia-tech-db/eva/blob/master/test/integration_tests/test_select_executor.py.

Co-authored-by: Gaurav Tarlok Kakkar <gaurav21776@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

initial inclusion of frigate chart billimek/blakeshome-charts
3 participants
@brujoand @blakeblackshear @billimek