Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix array out of range error in reviews #11059

Merged
merged 2 commits into from
Apr 22, 2024
Merged

Fix array out of range error in reviews #11059

merged 2 commits into from
Apr 22, 2024

Conversation

hawkeye217
Copy link
Collaborator

Loading reviews for a date in the past that had no reviews caused an array out of range error.

Copy link

netlify bot commented Apr 21, 2024

Deploy Preview for frigate-docs canceled.

Name Link
🔨 Latest commit f9d0350
🔍 Latest deploy log https://app.netlify.com/sites/frigate-docs/deploys/66258ef7d95516000867f89c

Copy link
Sponsor Collaborator

@NickM-27 NickM-27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems like this would return the number of items as html or an array of that is null based on ?? right?

@hawkeye217
Copy link
Collaborator Author

It seems like this would return the number of items as html or an array of that is null based on ?? right?

Yeah. I wasn't seeing the html output for -1 anywhere, but you're totally right. I updated the check to be the same as your existing check a few lines below it

@NickM-27 NickM-27 merged commit acadfb6 into dev Apr 22, 2024
13 checks passed
@NickM-27 NickM-27 deleted the fix-loading-crash branch April 22, 2024 01:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants