Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FEAT: Filter Multi Select #3367

Merged
merged 1 commit into from
Dec 12, 2022

Conversation

NickM-27
Copy link
Sponsor Collaborator

@NickM-27 NickM-27 commented Jun 21, 2022

Implementation of #1941 & #2608

WIP ToDo:

  • Update internal buttons to use labels instead of label
  • Use cameras, sub_labels, zones correctly
  • General Clean up
  • Fix sizing of dropdown
  • Format items to remove _
  • Update HTTP docs
  • Set min width on filter headers for better mobile view
  • Handle , in filter names (like sub labels with multiple people)

Demo

Screen.Recording.2022-06-22.at.9.48.26.AM.mov

@NickM-27 NickM-27 marked this pull request as ready for review June 22, 2022 17:26
@NickM-27 NickM-27 marked this pull request as draft June 30, 2022 13:16
@NickM-27 NickM-27 changed the title Filter Multi Select FEAT: Filter Multi Select Jun 30, 2022
@NickM-27 NickM-27 force-pushed the filter-multi-select branch 2 times, most recently from 26dfd52 to bd3d0bb Compare June 30, 2022 16:46
@johnmarksilly
Copy link
Contributor

Looks nice 🗡️

@NickM-27 NickM-27 added the enhancement New feature or request label Sep 23, 2022
@NickM-27 NickM-27 changed the base branch from release-0.11.0 to dev September 25, 2022 02:38
@netlify
Copy link

netlify bot commented Nov 2, 2022

Deploy Preview for frigate-docs ready!

Name Link
🔨 Latest commit 9de21b6
🔍 Latest deploy log https://app.netlify.com/sites/frigate-docs/deploys/6395fc1cb2d0d100095822e3
😎 Deploy Preview https://deploy-preview-3367--frigate-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@NickM-27 NickM-27 marked this pull request as ready for review November 2, 2022 13:51
@NickM-27 NickM-27 force-pushed the filter-multi-select branch 2 times, most recently from abb8471 to 1d8f31f Compare November 19, 2022 13:49
@blakeblackshear blakeblackshear merged commit b1ec56d into blakeblackshear:dev Dec 12, 2022
@NickM-27 NickM-27 deleted the filter-multi-select branch December 18, 2022 00:36
@DrSpaldo
Copy link

I’m not sure if this is the related PR for what I’m suggesting, I hope it is.. would be be possible for the select all button to also have the opposite effect when everything is selected? And de select all. It is tedious when I have 10 cameras to only select one as you have to go and individually select the other 9. Would be better to deselect all, then just select 1. Hopefully that makes sense

@NickM-27
Copy link
Sponsor Collaborator Author

I’m not sure if this is the related PR for what I’m suggesting, I hope it is.. would be be possible for the select all button to also have the opposite effect when everything is selected? And de select all. It is tedious when I have 10 cameras to only select one as you have to go and individually select the other 9. Would be better to deselect all, then just select 1. Hopefully that makes sense

the camera button to the right of the name is there to select that single one only

@DrSpaldo
Copy link

the camera button to the right of the name is there to select that single one only

Haha, I'm an idiot... Perfect, thanks @NickM-27

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature Request - Filter Out Particular Cams in Events View Event filter drop-down select multiple
4 participants